CVS log for plugins/gpg/gpg_functions.php
	Help

Request diff between arbitrary revisions

- save $gpg_onetimepad in the COOKIE, not the session.
- resolves long-standing insecurity in passphrase caching

-re-added code to force old exec interaction method unless system option sets use_proc_open=true

- improved notation for expanded HTTPS check to make the logic more clear

- added check for $_SERVER['HTTP_X_HTTPS'] to account for proxy vars
  - check suggested by Roland Schulz

-added check to see if user trusts system keyring before setting it in InitGnuPG function
-added system and user's trusted keys to trustedKeys array in GnuPG object during InitGnuPG

- removed trailing whitespace

-added function to initialize GnuPG object with correct parameters

-E_ALL changes, proc_open addititons
bug 29

-added rawoutput to gpg_parse_output

- E_ALL fixes
- added additional errors to gpg_parse_output
- fixed code formatting for readability

-E_ALL fixes

-changed trustdb update function to use centralized gpg_execute code

-added debug output to gpg_parse_output

-added note about secret key expiration as well as trapped public key unusable errors in gpg_parse_output

-added redirection of stderr in gpg command for update trustdb
-added more debug output to update trustdb function

-added output of gpg results if debug is on in gpg_update_trustdb

-added gpg_update_trustdb function for updating the trust database
-added $return['untrusted'] flag when parsing gpg output, to tell if a key is untrusted

-added array dimensioning at the beginning of parse gpg output function

-added trap for public key not found error in the gpg_parse_output function
bug 28

-added check for BAD signature as well as Bad

-added verified line to gpg_parse_output to allow operation within verification of signatures on attachments

-added certain trusted key warnings to signature line so that they appear after the signature
when reading a message

-added lookup for insecure_mem_warning to parse_output
-moved check for insecure_mem_warning after catching the error, so it can be properly ignored
bug 113

-changed getPref to use $data_dir instead of $safe_data_dir

-added safe_data_dir and getHashedDir calls to gpg_functions.php
bug 116

changed parameters for pop-up window
- now allows scollbars and resizing
Bug 120

- added security breach trodo to gpg_add_help_link fn
Bug 70

added missing " in gpg_add_help_link fn
Bug 70

- added fullscreen option to gpg_add_help_link fn
Bug 70

- updated help popup window attributes

-moved trustdb messages to info
-added checking trustdb to info

-removed WARNING: line from message was not integrity protected message

-added window properties to gpg_help_link pop-up
Bug 101

- updated help file path to use SM_PATH constant

-extended gpg_stripstr to possibly strip another string than gpg:
-added error messages for key signature warnings
-made all key signature warnings into warnings instead of errors

-added gpg_parse_output function with all gpg messages consolidated into one place
bug 107

-added debug flag passing within cacheable/cached functions

change to use SM_PATH

added debug text to new passphrase caching functions

removed gpg_makePage function, as it is no longer used

-Added functions to check for options to cache passphrase
-Added function to check for a cached passphrase (with all options correctly set).
bug 66

minor mod to gpg_section_header fn

infrastructure changes to support removal of MakePage functions

fixed problems apparent in the xgettext index
Bug 35

added better directory tests to getTempDir fn

- added 2 new functions:
  - gpg_section_header() - displays a consistant header
  - gpg_add_help_link() - generates the Help link HTML

corrected phpdoc warnings after updates

added @package and @author tags

-Added gpg_verify_passphrase function
-Uses signing code to check if a passphrase for a particular key is correct

minor changes to HTML rendering
Bug 65

cleaned up some of the HTML in gpg_makePage

-changed call to mt_rand to use 2 parameters
-modified all caching functions to use $cached_passphrase instead of $passphrase
bug 40

- fixed syntax error in SQGetGlobalVar in cache fn's

Fixed cut and paste error in the die command of the cache fn's

inital checkin of passphrase caching functions:
- gpg_set_cached_passphrase
- gpg_get_cached_passphrase
- gpg_clear_cached_passphrase
Bug 40

removed references to getstart.mod

added missing :

added smoptions target to backlink in gpg_makepage fn

- modified to use backlink option on gpg_makepage fn
- modified gpg_makepage fn to be ready for gettext localization
Bug 35

adding escape routes to options suite.  The previous 'back' link now only appears if requested (new arg to makePage).  This isn't done by any means, but at most it's as broken as it was, so it's an improvement.

added code to better select temporary directory in gettempdir fn

added tags for phpdoc

changed file include lines so it would work from hook in compose.php
Bug 26

fixed cut and paste typo error in fn deleteTempFile

cleaned up comments

fixed indents to remove irregular use of tabstops - no functional change

fixed typo in editor highlighing in line 467

Updated temp file functions to allow for secure deletion of temp files
- added make_seed fn
- added rand_string fn
- added file overwrite calls to _deleteAtShutdown fn
- added deleteTempFile fn

added functions for temporary files and directories cribbed from Horde code

fixed <script> tag syntax in gpgMakePage to correct for strict tag checking in Opera

moved $GPG_VERSION and fn gpg_version to gpg_pref_functions.php file

add pupdate_version function for compatibiltiy to Plugin Updates plugin

comment out debug in gpg_setglobal by default.  it is too voluminous to be of much use.

fixed typos in debug

added debug to gpg_setglobal

fixed $name, $value mappings

fixed typo on line 151

- create gpg_setglobal to get around SM's getglobal function
- update gpg_encrypt to use ne gpg_setglobal function
Bug 22

updated GPG_VERSION to 1.1

fixed comment typos -non-functional change

- updated gpg version to 1.0.2
- added function header comment blocks to all functions

- modified to use the new broken out *_function.php files

- Bug fixing in the accept passphrase section of _sign_message

- Initial work to accept passphrase in popup window and use for signing

- Added comment to the sign_message function where the hardcoded keyID is.
  Need to fix this soon.

- modified the sign_message function to not accept rcpt list, not used

Added Joel's fix for the extra line after the GPG MESSAGE header

Fixed handling of missing keys which cause gpg to not encrypte the message - "encryption failed" warnings

Added check for https connection

Added Tyler's gpg_sign_message function

Added missing bracket at line 188 - credit Tyler

Patched to fix broken if staetments and debug tests - credit Tyler
Removed Superflous includes
fixed typo on line 579c590 >global $path_to_gpg

minor syntax issues resolved

Final Edits for Release 1.0

Added gpg_list_keys function and updated gpg_encrypt to use trusted_key preference again.

updates to use more prefs selections

Changed all command code to utilize global $path_to_gpg loaded from preferences file

Added infrastructure function gpg_generate_keypair and fixed strpos usage in gpg_encrypt.

added vinay's changes for encrypt

Bracketed remaining echo statement in if $debug in function gpg_encrypt

removed escapeshellarg for returntext in function gpg_encrypt since we use the --armor command in gpg.

changed back to escapeshellarg for body only in function gpg_encrypt. we will rely on SM to scrub email addresses.

Merged vinay's changes.

Fixed escapeshellcmd to escape the entire gpg command string in function gpg_encrypt.

Changed a comment to test checkin from laptop.

fixed sysntaxt errors in gpg_recv_key fuction after integrating to keyserver.mod

added gpg_recv_key function

updated all functions to user system $data_dir for prefs and $data_dir/$username.gnupg as the --homedir for gpg

added support for system preferences

added beginnings of keyserver functions

updates to functions to prepare for keyserver lookup

edited key/ring import functions to echo nothing unless $debug is set and return the resultstring from the gpg comand as a string

fixed function gpg_import_key to use user keyring rather than system keyring

added comments and worked around hack code

mannually appended log entries

fixed $Log

changed gpg_MakePage to point to correct gpg plugin functions instead of sqspell functions

Added ID and Log tags

GPG Project repository

Initial revision