CVS log for plugins/gpg/gpg_encrypt_functions.php
	Help

Request diff between arbitrary revisions

-changed gpg returncode message to a warning instead of an error

- Allow multiple recipients in Encrypt to Self list.
- Test System ADK for missing key error
- Test Encrypt to Self recipient(s) for missing key error
- cleaned up indents and comments
Bug 173

-added check for email address in encr_to_self prefs.  Ignore if not there.

-removed homedir from main decrypt line
-changed order to trusted key and keyring in command line

- removed troublesome blank line at end of file

- patch for Apple Mail with the GPGMail
- provided by Heath Kehoe
Bug 159

-changed functions to operate properly with new proc_open methods
bug 29

-E_ALL changes

-removed duplicate command strings
-changed to use gpg_parse_output within gpg_execute, no longer needed externally

-changed to use centralized gpg_execute function

- fixed the $returnvalue parsing in gpg_encrypt
  and gpg_decrypt functions to use error array

localized strings discoverd by Alex Lemaresquier during French translation

Tighten handling of parsed addresses even further
- added ';' as 4th parameter to parseAddress
  - credit to Noam Rathaus of Beyond Security Inc for the code trace
- added escapeshellarg around each returned address
Bug 139

-added debug to update_trustdb function call

-changed update trustdb command to use centralized function
-only check trustdb when untrusted keys are found

-added trustdb check when decrypting messages

-removed data_dir from system keyring file, since it's added earlier now

changed instances of $system_keyring_file = $safe_data_dir to
   $system_keyring_file = $data_dir becasue $safe_data_dir is a
   hashed dir on a per-user basis

-added extra_cmd to the command line for the case of no file to encrypt
bug 28

- added corporate signature to gpg_decrypt
- fixed mis-handling of trusted system key in gpg_decrypt and gpg_encrypt fn
Bug 28

-changed all getPref calls to use data_dir instead of safe_data_dir
bug 116

-added use of getHashedDir to $data_dir in encrypt/decrypt for safely hashed dirs
bug 116

-removed all parsing of gpg output, changed to call gpg_parse_output instead
bug 107

-added ability to decrypt to an output file
-adds ability to decrypt attachments from outlook
bug 65

-readded changes to allow decryption of files with embedded filenames

-moved --decrypt filename to end of commandline, so that gpg will properly decrypt attachments with gpg_decrypt

changed 'gpg: Oops:' to warning in gpg_decrypt fn

localized some error strings
Bug 35

modified all localized strings to use double quotes.
Bug 35

- first pass at handling $filename in gpg_decrypt fn
Bug 56

- rearranged order of parameters in gpg_decrypt fn
Bug 56

added keydb errors to list in gpg_decrypt fn

added keydb erros to list in gpg_decrypt fn

added "Primary key fingerprint:" to info list

corrected phpdoc warnings after updates

added @package and @author tags

- added escapeshellarg to gpg_encrypt command for filenames with spaces
- trap for 'usage' syntax error in gpg command output
- improve debug error on failed attachment encrypt
Bug 74

added --force-mdc flag to gpg_encrypt fn to deal with:
  gpg: WARNING: message was not integrity protected
Bug 69

back out the block that stickas anything else in warnings,
  as it produces dups

re-integrated  patch provided by Magyar Dénes to
  strip errors from body in gpg_decrypt
Bug 67

added 'gpg: Oops:' to errors array in gpg_decrypt fn
Bug 67

-Added extra check for existance of file to encrypt in gpg_encrypt
-Removed --output - argument to gpg when encrypting a file
bug 26

patch submitted by Magyar Dénes breaks decrypt from encrypt on send
- backing out the ereg_replace commands for now

added patch submitted by Magyar Dénes to work around:
- insecure memory warning now controlled by pref file
- add \n linefeeds for system OS's that don't process
  textarea submits properly in gpg_encrypt

added 'gpg: Oops:' (trustdb errors) to warnings.

move location of --armor in gpg_encrypt fn

- added missing '$' to https_check in gpg_encypt and gpg_decrypt fn's
- credit to Joshua Vermette for noticing this bug.

add ADK check and switches to gpg_encrypt fn

added tags for phpdoc

added error check for 'no such file or dir' in gpg_encrypt fn

gpg_ecrypt fn:
- added check to reload 'globals' if we are called without pref vars beign set.
- added additional error conditions
Bug 26

trim header information on return from gpg_decrypt fn
Bug 38

- added $filename to gpg_encrypt fn
- mangled command line to account for file encryption in gpg_encrypt fn
- added additional error handling to gpg_encrypt fn
Bug 12

- Added code to correctly process encrypt to partial recipients preference
- cleaned up excessive debug info in gpg_encrypt fn
Bug 36

- added check in gpg_encrypt fn to return error if cyphertext is empty
- romoved todo item for same in gpg_encrypt.php

added common debug output to gpg_parse_address fn

Fixed an address parsing bug. The Squirrelmail address look up functions treat a nickname without a match in the address book as an address at domain: i.e. "nick" is seen by squirrelmail as "nick@domain". Our GPG functions misrendered that as "nick@", which meant passing the wrong thing to GPG.

New behavior translates "nick", not appearing in address book, as "nick@" . $GLOBALS['domain'].

fixed indents to remove irregular use of tabstops - no functional change

added failsafe check to trusted key handling to make sure key is actually set

Re-enabled shared 'corporaet' or 'system' keyring support
 - added checks for appropriate preferences to gpg_encrypt fn
 - tested all configurations
 - added trustedkey id pref for shared keyring, tested same
 - significantly improved completeness of error parsing in gpg_encrypt fn
Bug 32

-removed a small bug where a small was being appended to the body of
a message before it was encrypted

- make changes to allow encrypt & sign without needing a temp file.
It seems that "echo 'passphrase'\n'body'" didn't work but
"echo 'passphrase\n''body'" did. I'm not sure why but it works now.
Bug 11

 - integrated Ryan's patch to use temp file
 - integrated GetTempFile fn
 - cleaned up security settings
 - Encrypt&Sign now verified working
Bug 11

updated gpg_encrypt fn to properly support no passphrase on sign
Bug 11

modified gpg_encrypt fn to support 'encrypt & sign'
Bug 11

added command modifications from pre-merge v 1.16 to add signing functionality to gpg_encrypt
Bug 11

added htmlspecialchars to gpg_parse_addr funtion to fix display bug in SM 1.4.0

- added more debug statements to gpg_decrypt
- load no_signing_passwd pref inside the gpg_decrypt fn
Bug 21

- mangled command string in gpg_decrypt to omit --passphrase fd0 if user has set no_signing_passwd
Bug 21

separated out if statement to change command if the user has no_signing_passphrase set to true.
Bug 21

fixed typo in elseif definition in gpg_decrypt function

- added check for no_signing_passphrase to gpg_decrypt fn.
- Should execute without errors if user has no_signing_passphrase turned on.
Bug 21

added check for no_signing_passwd  in fn gpg_decrypt
 - the user will not see an error if they have selected
   no_signing_passwd and submit without a passphrase

improved error handling in gpg_encrypt and gpg_decrypt functions by
replacing strpos checks with substr_count checks
Bug 8

improved error handling strings

fixed typo on line 389, missign second right paren before 'break'

Convert gpg_decrypt fn to use plaintext language instead ofcyphertext lang.
Bug 8

clean up comments in gpg_parse_address fn
Bug 3

address parsing in gpg_parse_address function now works for sm 1.2.x and sm >=1.3.x
tested on sm 1.4rc2a
fixes bug# 3
Bug 3

fixed syntax error in gpg_decrypt, extra curly brace

manual fix of $log entries

basics of decryption
gpg_decrypt function should work when called with body and passphrase
Bug 8

Bug 6
Add to SM 1.4 parsing code

- progress towards SM v >=1.3.1 compatibility
- path selection for includes now works on both
  SM 1.2.x and SM >= 1.3.1
- path selection for version check in gpg_parse_address
  now correct
- fixed skipped_keys bug in fn gpg_encrypt

added version checknig code to gpg_parse_address
we now run code based on SM version

fixes gpg_parse_address function to only return an array, not process it into a recipient list

added gpg_parse_address function

- Initial breakout of the *_functions.php file